Skip to content

OpenAM JAXB 4.x migration#1067

Open
rohithjayak wants to merge 4 commits into
OpenIdentityPlatform:masterfrom
cisco-open:JAXB4_x_Resolve_Conflict_pom_xml
Open

OpenAM JAXB 4.x migration#1067
rohithjayak wants to merge 4 commits into
OpenIdentityPlatform:masterfrom
cisco-open:JAXB4_x_Resolve_Conflict_pom_xml

Conversation

@rohithjayak

Copy link
Copy Markdown

This PR contains the OpenAM migration to JAXB4.x which was discussed in the case: #963

Rohith Jayakumar and others added 2 commits July 9, 2026 15:42
@vharseko vharseko requested a review from maximthomas July 10, 2026 20:48
@vharseko

Copy link
Copy Markdown
Member

This branch has conflicts that must be resolved (rebase to origin/master or merge from origin/master)

@maximthomas

Copy link
Copy Markdown
Contributor

Hi @rohithjayak
Thank you for the contribution. We appreciate the effort you put into the PR. But there are several issues with the PR I have to point out:

  • You have removed JDK 17 and older support, but some users are still on 11, so we need to maintain older JDK support
  • You upgraded already to JAXB 4 which is Jakarta EE 10, but OpenAM is still on Jakarta EE 9, we have plans to migrate to Jakarta EE 10 in future.
  • There is already a PR that migrates to JAXB 3, and I think it has more solid approach, as it restores JAXB classes generation from schema. JAXB3 Migration #1023

@vharseko

Copy link
Copy Markdown
Member

Thanks for the work here, @rohithjayak. Adding a couple of notes on top of @maximthomas's review — mainly about CI status and about sequencing the migration.

CI status. The PR is currently red across the whole build matrix (every build-maven job on all OS/JDK combinations, plus CodeQL). The build never reaches compilation — it fails at POM parsing:

[FATAL] Non-parseable POM openam-shared/pom.xml: Unrecognised tag: 'dependency'
(position: START_TAG seen ...</version>\n <dependency>... @163:21) @ line 163, column 21

So openam-shared/pom.xml has a stray <dependency> outside a <dependencies> block around line 163 — this looks like a leftover from the master merge/conflict resolution (it matches the branch name and the earlier conflict note). Fixing that first would let CI actually build the branch so we can review the real changes.

On sequencing. This PR bundles three large changes at once: the javax.xml.bindjakarta.xml.bind namespace move, the jump to JAXB 4.x (Jakarta EE 10), and dropping JDK ≤17. That's a lot to validate in a single step, and as Maxim noted OpenAM is still on Jakarta EE 9 and needs to keep JDK 11.

Could we do this more gradually? The natural first step is #1023 (JAXB 3 / Jakarta EE 9): it keeps JDK 11+ support, restores JAXB class generation from schema, and its CI is fully green and mergeable today. Landing #1023 first moves us onto the jakarta.* namespace on a stable footing; the JAXB 4 / Jakarta EE 10 bump (this PR) then becomes a much smaller, isolated follow-up for when the project actually moves to Jakarta EE 10.

Happy to help rebase this on top of #1023 once it's merged.

Update pom.xml with correct dependency tag format
@rohithjayak

rohithjayak commented Jul 13, 2026

Copy link
Copy Markdown
Author

Hi @maximthomas, @vharseko ,
Thanks a lot for reviewing these changes and providing inputs.
Sorry the dependency tag got missed while resolving the conflict, i have made that change to add one closing dependency tag now and pushed it, could you please check if things are fine?
The dropping of JDK ≤17(i.e., only support JDK 21) was specifically done to make it compatible with our product, let me check on if it is feasible to make it backward compatible as well, If you already know the changes, please let me know i can incorporate it and update it in the PR.
And regarding the PR sequencing, let me check with my team internally and get back...

Thanks,
Rohith Jayakumar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants